Skip to content

feat: Do not display the review pop-up again if the user clicks no#752

Open
Elouan1411 wants to merge 1 commit into
mainfrom
rating-pop-up-dont-ask
Open

feat: Do not display the review pop-up again if the user clicks no#752
Elouan1411 wants to merge 1 commit into
mainfrom
rating-pop-up-dont-ask

Conversation

@Elouan1411
Copy link
Copy Markdown
Contributor

@Elouan1411 Elouan1411 commented Apr 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 13:17
@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from e6a47f9 to acf6c03 Compare April 21, 2026 13:18
Copilot AI reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a persistent “do not show again” flag to the in-app review gating logic so that once a user declines (via the negative/feedback path), the review prompt won’t be shown in future sessions.

Changes:

  • Introduce a new DataStore preference key (DO_NOT_SHOW_AGAIN_KEY) with a default value.
  • Update shouldDisplayReviewDialog to also depend on the new “do not show again” flag.
  • Persist the “do not show again” flag when the user chooses the feedback/negative action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
InAppReview/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt Includes the new flag in the dialog display conditions and writes the flag when the user selects the negative/feedback path.
InAppReview/src/main/kotlin/com/infomaniak/core/inappreview/AppReviewSettingsRepository.kt Adds the new DataStore key and default initial value wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ...iew/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit 8ec8440)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Race Condition

In onUserWantsToGiveFeedback, both resetAppReviewSettings() and disableReviewDialog() launch separate coroutines on Dispatchers.IO without synchronization. If resetAppReviewSettings() executes after disableReviewDialog(), it may overwrite the DO_NOT_SHOW_AGAIN_KEY value back to false, causing the review dialog to appear again despite the user having already chosen to give feedback. These operations should be combined into a single atomic transaction or properly sequenced to ensure the "do not show again" flag persists.

 
override fun onUserWantsToGiveFeedback(feedbackUrl: String) {
    onUserWantsToGiveFeedback?.invoke()
    resetAppReviewSettings()
    WebViewActivity.startActivity(activity, feedbackUrl)
    disableReviewDialog()

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Persistent review updated to latest commit 5225da1

@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 5225da1 to acf6c03 Compare April 21, 2026 13:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Failed to generate code suggestions for PR

@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from acf6c03 to e3c8fbb Compare April 21, 2026 14:13
@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch 2 times, most recently from e658c64 to 8ec8440 Compare April 21, 2026 14:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Persistent review updated to latest commit 8ec8440

@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 8ec8440 to 2ca15f9 Compare April 22, 2026 07:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Failed to generate code suggestions for PR

@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 2ca15f9 to 9acb957 Compare April 24, 2026 13:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

Failed to generate code suggestions for PR

@Elouan1411 Elouan1411 force-pushed the rating-pop-up-dont-ask branch from 9acb957 to b24e902 Compare April 27, 2026 09:49
FabianDevel
FabianDevel requested changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@FabianDevel FabianDevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't add a new preference.
The logic now is that either way if you click on one or the other button, the popup should not come back.
So you can use a single preference for both

The best should be that you don't do anything by default, and just move the logic of the threshold on the onDismiss action

@FabianDevel FabianDevel force-pushed the rating-pop-up-dont-ask branch from b24e902 to c8199eb Compare May 21, 2026 12:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Copilot code review Copilot Copilot left review comments

@FabianDevel FabianDevel FabianDevel requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Elouan1411 Elouan1411

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elouan1411 @FabianDevel